AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<maxim.kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 5 Apr 2010 16:00:23 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: Maxim Kozlovsky <maxim.kozlovsky@lsi.com>
Subject: please review 35160
Message-ID: <20100405160023.5b4d772d@ripper.onstor.net>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Change 35160 by andys@ripper on 2010/04/05 15:55:28 *pending*

        Fix bug in sibyte ethernet driver where a byte value greater
        than 0x7f in the MAC address could really screw up the stack.
        Fix found by Sam Revitch and David Olien.

        
        reviewed by

Affected files ...

... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/net/sb1250-mac.c#3 edit

$ p4 diff drivers/net/sb1250-mac.c==== //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/net/sb1250-mac.c#3 - /homes/andys/src/tuxrx/linux/kernel/linux-mips-2.6/drivers/net/sb1250-mac.c ====
2939c2939
< extern char *magicmanagementbusringconfig;
---
> extern unsigned char *magicmanagementbusringconfig;
2941c2941
< char *magicmanagementbusringconfig;
---
> unsigned char *magicmanagementbusringconfig;
3009c3009
<               char ons_mac_str[] = "00:07:34:00:00:00";
---
>               unsigned char ons_mac_str[] = "00:07:34:00:00:00";
