AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Larry.Scheer@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	DEC609CD0E54B2448DAF023C89AE9755EB50C555@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 6 Apr 2010 13:37:10 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Scheer, Larry" <Larry.Scheer@lsi.com>
Subject: Re: Forgot to enter Reviewed By NOT SELF in description for
 changelist 35160
Message-ID: <20100406133710.375d415d@ripper.onstor.net>
In-Reply-To: <DEC609CD0E54B2448DAF023C89AE9755EB50C555@cosmail02.lsi.com>
References: <E1NyxWY-0006Hg-MF@liszt.onstor.net>
	<20100405191630.2e3b52e6@ripper.onstor.net>
	<DEC609CD0E54B2448DAF023C89AE9755EB50C553@cosmail02.lsi.com>
	<20100406100915.7863503d@ripper.onstor.net>
	<DEC609CD0E54B2448DAF023C89AE9755EB50C555@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 6 Apr 2010 12:56:25 -0600 "Scheer, Larry"
<Larry.Scheer@lsi.com> wrote:

> The same trigger that rejects the email sends this email message.
> Several newbies have sent me thank you email messages because the
> instructions told them what they needed to do. So the email message
> does help. I also get a copy so when I see about 6 of these in a row
> I contact the developer and tell them what they need to do.
> 
> Hmm, a bug you say? Maybe it was my "needle Andy" feature that fires
> off at random times in random p4 commands. ;-)

That sounds like an excellent idea, BTW.

But I think there's something I'm not getting.  It passed the check and
was submitted, so why would I get this email?  Ooooooooo- it didn't
pass the check the first time, that's right, I forgot.

'Stupid email' -Homer

> Later dude,
> 
> Larry
> ________________________________________
> From: Andrew Sharp [andy.sharp@lsi.com]
> Sent: Tuesday, April 06, 2010 10:09 AM
> To: Scheer, Larry
> Subject: Re: Forgot to enter Reviewed By NOT SELF in description for
> changelist 35160
> 
> You're killing me.  But I didn't botch the reviewer line, or any of
> that other stuff, not this time anyway ~:^)  The change went through
> so this would seem to be some kind of bug.  Also, there's no reason to
> send an email, as the submit just gets rejected at the time.
> 
> On Tue, 6 Apr 2010 09:21:52 -0600 "Scheer, Larry"
> <Larry.Scheer@lsi.com> wrote:
> 
> > Pretty cool huh?
> >
> > If you botch the reviewed by line, use your name as the reviewer,
> > use an invalid reviewer name, or forget it entirely you get this
> > very helpful and cherry message!
> >
> > Enjoy,
> >
> > L.
> > ________________________________________
> > From: Andrew Sharp [andy.sharp@lsi.com]
> > Sent: Monday, April 05, 2010 7:16 PM
> > To: Scheer, Larry
> > Subject: Re: Forgot to enter Reviewed By NOT SELF in description for
> > changelist 35160
> >
> > OK, wtf?
> >
> > On Mon, 5 Apr 2010 19:24:14 -0600 perforce
> > <perforce@liszt.onstor.net> wrote:
> >
> > > Please run p4 change 35160 and enter the Reviewed By information
> > > as well as Bug ID, if applicable. The Reviewed By information
> > > takes the following form in the change list: In the description
> > > section add the line: Reviewed by: p4user
> > > Where p4user is a valid perforce account authorized to review your
> > > change. Type p4 users to see a list of perforce accounts.
> > >
> > > Then run p4 submit -c 35160 to resubmit the corrected job.
