AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	1270768714.26360.375.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 8 Apr 2010 16:59:41 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Subject: Re: please review 35213
Message-ID: <20100408165941.59ebf610@ripper.onstor.net>
In-Reply-To: <1270768714.26360.375.camel@rendellf>
References: <20100408141939.077f72de@ripper.onstor.net>
	<1270768714.26360.375.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 8 Apr 2010 17:18:34 -0600 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> 
> On Thu, 2010-04-08 at 15:19 -0600, Andrew Sharp wrote:
> > Change 35213 by andys@ripper on 2010/04/07 18:37:13 *pending*
> > 
> > 	Move kernel watchdog setup and initialization to common
> > directory.
> > 
> > 	Clean up chatty-kathy boot up printks in various drivers
> > and modules.
> > 
> > 	reviewed by
> > 
> > Affected files ...
> > 
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/Makefile#4
> > edit
> ok
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/common/Makefile#1
> > edit
> ok
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/common/kern-wdog.c#1
> > add
> ok
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/cougar/time.c#1
> > edit
> ok
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/Makefile#1
> > edit
> ok
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/prom.c#3
> > edit
> ok
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/setup.c#3
> > edit
> ok
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/time.c#2
> > delete
> ok
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/prom.c#2
> > edit
> ok
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/rcon.c#9
> > edit
> 1061,1064: shouldn't need to comment these out, the macro w/o
> RCON_DEBUG defined will handle it.
> 
> I think it would be better convert all of those printks to use
> RCON_PRINTK.  Same effect anyway.

OK, fixed. I think.  I fixed RCON_PRINTK a tad as well, so rcon.h
added to changelist.

> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee.h#5
> > edit
> ok
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-app.c#10
> > edit
> ok
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-fwd.c#12
> > edit
> ok
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-init.c#12
> > edit
> ok
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-poll.c#11
> > edit
> ok
> 
> 
