AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<pshedage@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	4BBF6246.2060809@lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 9 Apr 2010 10:39:51 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: Pravin <pshedage@lsi.com>
Subject: Re: Please review the changes for defect TED00028036.
Message-ID: <20100409103951.3b7ca620@ripper.onstor.net>
In-Reply-To: <4BBF6246.2060809@lsi.com>
References: <04FB0DCDF7702C409F7E481C74E6A9BF020F99E2DD@inbmail02.lsi.com>
	<20100401112150.506e8fe6@ripper.onstor.net>
	<04FB0DCDF7702C409F7E481C74E6A9BF020F99E2DF@inbmail02.lsi.com>
	<20100406115649.75220a0d@ripper.onstor.net>
	<4BBCD0C9.4090101@lsi.com>
	<4BBF6246.2060809@lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit


= Change 35231 by pshedage@pravin1 on 2010/04/09 10:03:36 *pending*
= 
= 	changes related to TED00028036 
= 	   Headline: CLI: nfs share modify: doesn't check for valid IP for client list


In addition to the bug ID and description, please include a description
of the changes themselves.  You can edit the changelist, including the
comments, with the command

p4 change 35231




nfx-tree/code/ssc-nfxsh/cmd_nfs.c

     line 370 ip_any, ip_lb, and ip_none are used before being set to
     any value





On Fri, 9 Apr 2010 11:22:14 -0600 Pravin <pshedage@lsi.com> wrote:

> Hi Andy,
>     Please review the changes for defect TED00028036.
> 
> Changelist number: 35231
> 
> compile machine IP : 10.0.0.23
> client name: pravin1
> file    :  cmd_nfs.c
> path :      /homes/pshedage/pravin1/dev/nfx-tree/code/ssc-nfxsh/cmd_nfs.c
> 
>     //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_nfs.c
> 
> 
> pshedage@compile2:~/pravin1/dev/nfx-tree/code$ p4 describe 35231
> Change 35231 by pshedage@pravin1 on 2010/04/09 10:03:36 *pending*
> 
>         changes related to TED00028036
>            Headline: CLI: nfs share modify: doesn't check for valid
> IP for client list
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_nfs.c#24 edit
> 
> 
> 
> 
> 
> Pravin wrote:
> > Hi Andy,
> >     Please review the changes for defect TED00028036.
> >
> > Changelist number: 35205
> >
> > compile machine IP : 10.0.0.23
> > client name: pravin1
> > file    :  cmd_nfs.c
> > path :      /homes/pshedage/pravin1/dev/nfx-tree/code/ssc-nfxsh/cmd_nfs.c
> >
> >     //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_nfs.c
> >
> >
> >
> >   Thanks,
> > Pravin Shedage.
> >
> >
> >
> > Andrew Sharp wrote:
> >> Hi Pravin,
> >>
> >> I still need a perforce changelist number.  If you're not sure how
> >> to create one, let me know.
> >>
> >> Thanks,
> >>
> >> a
> >>
> >> On Tue, 6 Apr 2010 07:17:52 -0600 "Shedage, Pravin"
> >> <Pravin.Shedage@lsi.com> wrote:
> >>
> >>  
> >>> Hi Andy,
> >>>      Please review the changes for defect TED00028036.
> >>>
> >>> compile machine IP : 10.0.0.23
> >>> client name: pravin1
> >>> path :  /homes/pshedage/pravin1/dev/nfx-tree/code/ssc-nfxsh/cmd_nfs.c
> >>> file    :  cmd_nfs.c
> >>> Chages: p4 diff cmd_nfs.c
> >>>
> >>>    
> >>>>     struct  in_addr ip_lb, ip_any, ip_none;
> >>>>
> >>>>       
> >>> 368a371,380
> >>>    
> >>>>         inet_aton("0.0.0.0", &ip_any);
> >>>>         inet_aton("127.0.0.1", &ip_lb);
> >>>>         inet_aton("255.255.255.255", &ip_none);
> >>>>
> >>>>         if ((ip_any.s_addr == ip.s_addr) ||
> >>>>             (ip_lb.s_addr == ip.s_addr) ||
> >>>>             (ip_none.s_addr == ip.s_addr)) {
> >>>>                 fprintf(stderr, "IP address %s is reserved.\n",
> >>>> buff); return 0;
> >>>>         }
> >>>>       
> >>> Test:
> >>>
> >>>
> >>> g5r6 G5R6-T1 diag> nfs show
> >>> State: Enabled    Share path: /g5r6-t1-vol1
> >>> g5r6 G5R6-T1 diag> nfs share modify /g5r6-t1-vol1
> >>>  /IP address 127.1 is reserved.
> >>> Invalid IP address entry detected!
> >>> Error: NFS failure to add share with (127.1)!
> >>>
> >>> % Command failure.
> >>> g5r6 G5R6-T1 diag> nfs share modify /g5r6-t1-vol1
> >>>  /IP address 127.0.0.1 is reserved.
> >>> Invalid IP address entry detected!
> >>> Error: NFS failure to add share with (127.0.0.1)!
> >>>
> >>> % Command failure.
> >>> g5r6 G5R6-T1 diag> nfs share modify /g5r6-t1-vol1
> >>>  /IP address 255.255.255.255 is reserved.
> >>> Invalid IP address entry detected!
> >>> Error: NFS failure to add share with (255.255.255.255)!
> >>>
> >>> % Command failure.
> >>> g5r6 G5R6-T1 diag> nfs share modify /g5r6-t1-vol1
> >>>  /IP address 0.0.0.0 is reserved.
> >>> Invalid IP address entry detected!
> >>> Error: NFS failure to add share with (0.0.0.0)!
> >>>
> >>> % Command failure.
> >>> g5r6 G5R6-T1 diag>
> >>>
> >>>
> >>> Thanks,
> >>> Pravin Shedage.
> >>>
> >>>
> >>>
> >>>
> >>> ________________________________________
> >>> From: Andrew Sharp [andy.sharp@lsi.com]
> >>> Sent: Thursday, April 01, 2010 11:51 PM
> >>> To: Shedage, Pravin
> >>> Subject: Re: Please review the changes for defect TED00028036.
> >>>
> >>> Hi Pravin,
> >>>
> >>> Please just send me a changelist # that contains the change.
> >>> Part of the review process is to review the checkin comments, so
> >>> you should create a changelist for just this change, and put in
> >>> the checkin comments you intend to use.  After that, all I need
> >>> is the changelist # in question, and I can take it from there.
> >>>
> >>> Thanks,
> >>>
> >>> a
> >>>
> >>>
> >>> On Thu, 1 Apr 2010 01:10:58 -0600 "Shedage, Pravin"
> >>> <Pravin.Shedage@lsi.com> wrote:
> >>>
> >>>    
> >>>> Hi Andy,
> >>>>
> >>>>    Please review the changes for defect TED00028036.
> >>>>
> >>>> Problem Description:
> >>>>    CLI "nfs share modify": doesn't check for valid IP for client
> >>>> list.
> >>>>
> >>>> Testing:
> >>>>    I tested "nfs share modify" for following reserved ip
> >>>> addresses.
> >>>>    - "0.0.0.0"
> >>>>    - "127.0.0.1"
> >>>>    - "255.255.255.255"
> >>>>
> >>>> View Changes:
> >>>>    - To view changes use following steps
> >>>>    1. P4CLIENT=pravin1
> >>>>    2. P4CLIENT=pravin1 p4
> >>>> diff /homes/pshedage/pravin1/dev/nfx-tree/code/ssc-nfxsh/cmd_nfs.c
> >>>>
> >>>> Changed files:
> >>>>    //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_nfs.c
> >>>>
> >>>>
> >>>>    Thanks,
> >>>> Pravin Shedage.
> >>>>       
> >> .
> >>
> >>   
> >
> >
> 
