AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 16 May 2007 10:54:22 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: review for cl 23863
Message-ID: <20070516105422.46490f73@ripper.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

I lost the original email, here are my notes:

linux/Pkgs/binary/Rpm/libcomerr2-mipsel-cross-1.39+1.40_WIP_2006.11.14+dfsg-3.noarch.rpm

     ok

linux/Pkgs/binary/Rpm/support/debootstrap-0.3.3.2-2.noarch.rpm

     ok

linux/Pkgs/binary/Rpm/support/dpkg-1.13.25-2.i386.rpm

     ok

linux/Pkgs/binary/Rpm/support/dpkg-dev-1.13.25-2.noarch.rpm

     ok

linux/pkg-tools/mk-mipsel-deb-rootfs

     looks good

nfx-tree/Tools/init-local.mk

     TOP should not be set in an include file, only in Makefile 's that
     know what directory they are in.  You should be able to include an
     include file from a Makefile in any directory.
     
     You don't need both PATH_TO_ROOT and TOP, they are the same thing.
     I think.  TOP=../$PATH_TO_ROOT?  I don't understand that.  Hmm.

nfx-tree/Tools/tool-chain-pkg.mk

     i like it, i like it.  PATH_TO_LINUX probably shouldn't be
     conditional, but I don't think it will hurt anything for now.

