AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Bill.Fisher@lsi.com>,<brian.stark@lsi.com>,<maxim.kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 12 Apr 2010 13:32:10 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Fisher, Bill" <Bill.Fisher@lsi.com>
Cc: Brian Stark <brian.stark@lsi.com>, Maxim Kozlovsky
 <maxim.kozlovsky@lsi.com>
Subject: Re: tuxrx Branch Change List 34077 review requested
Message-ID: <20100412133210.1392bcad@ripper.onstor.net>
In-Reply-To: <4B4FDE26.50003@lsi.com>
References: <4B4FDE26.50003@lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Resending.  There's quite a few files in here where I say "integrate
over and keep all the changes" or something along those lines.  Look at
all the files in nfx-tree/code/{neteee2,tpl,ui} and any other of your
files that I ported over to the nfx-tree back in 2009.  I may not have
listed them all individually.  It's your responsibility to track them
down and take care of this since you wanted to do it this way.

I told you many times, that if you were going to put your stuff in the
kernel directories, then you had to take these changes, and that you
can't just blow it off.  File by file is how it's done.

Thanks,

a

On Thu, 14 Jan 2010 20:16:54 -0700 William Fisher <bill.fisher@lsi.com>
wrote:

> Folks:
> 
> Attached is the p4 describe of the change list to merge the
> common headers between the nfx-tree/Includes and the kernel
> one's residing in include/linux/onstor/...
> 
> In addition, this change list also includes the code changes
> to the nfx-tree to get the txrx module to compile
> using the Makefile.acpu and the new common headers in addition
> to the one's residing in code/sm-*/*.h
> 
> The virtual server hooks and specific areas which
> need to be converted to Rendell's new implementation
> have been ifdef'ed VIRTUAL_SERVER_IMPLEMENTED
> in the code/sm-vsvr, code/sm-stats and in the
> NFS, CIFS and NetBIOS directories which cover
> the acpu_conn structure changing and moving to
> now hang off the kernel socket structure. The
> tpl code manages this user_data area
> and also contains the old bind and connection
> structure used in the tpl API's.
> 
> If either Andy, Rendell or Max could review these
> changes, I can proceed to add them to the branch.


Here it is:

= Change 34077 by bfisher@fisher-tuxstor-new on 2009/12/18 15:45:16 *pending*
= 
= 	Fix duplicate headers, testing case
= 


I removed from the comments the deleted files that I have no comment
about their deletion, no need to spam you with all those.


This stuff has to at least compile, or at least it should if things like
DEBUG are defined, but removing BSD_ from various LIST macros ensures
that it will not.

Also, changing tv_sec, uint8, et. al. back to sec, uchar8, tells me that
you haven't properly brought over the the header files from nfx-tree.
Which is just one of the reasons that an integrate should be used, not
an add/delete.  You must double check those header files because of that.
It doesn't fall to me to do that for you.

Your checkin comment needs some sprucing up.




linux/kernel/linux-mips-2.6/include/linux/onstor/nfx-defs.h

     looks good

linux/kernel/linux-mips-2.6/include/linux/onstor/nfx-types-extra.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/nfx-types-extra.h

     line 34-42 80 column violations.  these comments are hella
     wordy.  i think the world knows what VOL_MAX_NAME must be, etc.
     many places in the file have the same problem.

     and, yes, code style is important, and, no we're not going to
     use a filter program for multiple reasons ~:^)

     line 137, i think max complained about this, but this is fine --
     someone can fill this in later once it's defined.

linux/kernel/linux-mips-2.6/include/linux/onstor/nfx-types.h

     line 12, ifndef _NFX_ERROR_H, this is wrong, this kind
     of processing takes place inside the included header file.
     just include the file, and if it doesn't have this logic, then
     add it to that file.

     line 19-20 just delete these then

     line 56 and 60, this is too ugly and error prone, suggesting that
     there may be multiple definitions for the same thing, which we
     can't do.

     line 125 i think we should get rid of this, and fix anything that
     uses it.  possibly that can wait for another day, however.

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-cifs/ntstatus.h

     line 54, we cannot do this.  we cannot have multiple definitions
     of the same thing.  i think that's what this means, anyway.

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-api.h

     in header files especially, i would prefer you use the
     angle-bracket syntax.  please.

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/acpu-conn-struct.h

     i hate 80 column violations



linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/pkt-queue-api.h

     line 607, this makes no sense.  a function declaration is applicable
     to both userspace and kernel?  huh?  and it's different at that?
     it has to be a different function in userspace, so it possibly be
     declared in a userspace header file somewhere.  no?
	 i believe it's legal to have two different declarations for the
	 same function name but with different arguments.  the compiler
	 will just apply whatever declaration matches.

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/pkt-queue-struct.h

     looks good

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/pkt.h

     looks good

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-timer/eee-timer-api.h

     line 17, wow, EEE has a different number of USECS_PER_SEC than
     the rest of the world?  I'd like it if we used the standard
     USECS_PER_SEC definition in the kernel.

linux/kernel/linux-mips-2.6/net/neteee-ui/rcon-shell.c

     looks good

linux/kernel/linux-mips-2.6/net/neteee2/eee-timer-api.c

     looks good

linux/kernel/linux-mips-2.6/net/tpl/pkt.c

     looks good

nfx-tree/Includes/bqueue.h

     >>delete nfx-tree/Includes/bqueue.h

     you can't delete this one.  max's changelist has many changes to
     it.  after max checks his changelist in, you will need to reconcile
     that one with yours before you check this in.  preferrably,
     "move" this one to the kernel location using p4 integrate.  please.

nfx-tree/Includes/eee/rpc/rpc.h

     line 184 and 153, if this is gone, it's gone, delete it from the
     struct  and don't mess up the comment formatting either.


nfx-tree/Includes/linux/typalooza.h

     i thought you deleted this file?  noway with all the ifndef then
     typedef stuff, that leads to bug-city.

     decide if you are deleting this file or not, as it seems that
     that is what you meant to do.



nfx-tree/Tools/init-ssc.mk

     line 62, 74, definitely not "the way".  the header files from
     the kernel will be installed in the usr/include area of the
     cross-build directory, and will be pulled in automatically.
     so no extra incdirs mods are needed.  we can work all this out
     with larry/rendell, but in the mean time, don't check this in.

nfx-tree/code/Makefile.acpu

     line 14,15, uh, please remove these extraneous lines which do
     not belong here.

     line 17/18, if you're gonna change it, change it.  no need to
     leave an old version of the line in here.

     lines 22,25, i left these in here in case someone smarter than
     me realizes that these are actually needed.



nfx-tree/code/neteee2/eee-timer-api.c

     >>delete nfx-tree/code/neteee2/eee-timer-api.c

	 please do not delete this file.  p4 integrate it over, and keep
	 all the changes.

nfx-tree/code/neteee2/eee-timer-api.h

     >>delete nfx-tree/code/neteee2/eee-timer-api.h

	 same goes with this file: p4 integrate it over, and keep all
	 the changes.

nfx-tree/code/neteee2/eee-timer.c

     >>delete nfx-tree/code/neteee2/eee-timer.c

	 same goes with this file: p4 integrate it over, and keep all
	 the changes.

nfx-tree/code/sm-audit/audit-msg.c

     lines17-25, please, please fix the header-spam, as i've
     said before. and you make fun of in the code of others.
     i'm guessing that types.h and slab.h are all that's needed out
     of this list.  maybe one of in.h or inet.h, but i would try
     compliling without them first.

nfx-tree/code/sm-audit/audit.c

     line 16-24, ok, there was no reason to paste this huge block
     of includes in every file, which I'm guessing is what i'm going
     to see.  please undo that?  if it wasn't there in the first place,
     it isn't needed.

     line 1614, no, this should remain is it was, this is a timespec
     number now.  again, please undo this.  for this and the one above,
     i will leave it to you to fix this everywhere rather than mention
     it over and over.  i do mention them again in places, but not
     every file.  just an FYI, Max has changed all his code over to the
     new definition.


nfx-tree/code/sm-authorization/auth-rpc-cmd.c

     looks good

nfx-tree/code/sm-authorization/auth-rpc.c

     line 19-27, yes, there was a reason why only slab.h was included.
     that's all that was needed.


nfx-tree/code/sm-authorization/author-api.h

     looks good

nfx-tree/code/sm-authorization/author-cmd.c

     looks good

nfx-tree/code/sm-authorization/author-includes.h

     looks good

nfx-tree/code/sm-authorization/author-sec.c

     looks good

nfx-tree/code/sm-authorization/author-ssc.c

     looks good

nfx-tree/code/sm-authorization/author-ssc.h

     looks good

nfx-tree/code/sm-cifs-rpc/cifs-pipe-ssc.c

     looks good

nfx-tree/code/sm-cifs-rpc/cifs-rpc-ed-hdr.c

     looks good

nfx-tree/code/sm-cifs-rpc/cifs-rpc-ed-srvsvc.c

     looks good

nfx-tree/code/sm-cifs-rpc/cifs-rpc-encdec.c

     looks good

nfx-tree/code/sm-cifs-rpc/cifs-rpc-mem.c

     looks good

nfx-tree/code/sm-cifs-rpc/cifs-rpc-srvsvc.c

     looks good

nfx-tree/code/sm-cifs-rpc/cifs-rpc-struct.h

     looks good

nfx-tree/code/sm-cifs-rpc/cifs-rpc-utils.c

     looks good

nfx-tree/code/sm-cifs-rpc/cifs-rpc-winreg.c

     looks good

nfx-tree/code/sm-cifs-rpc/cifs-rpc-wkssvc.c

     looks good

nfx-tree/code/sm-cifs-rpc/cifs-rpc.c

     looks good

nfx-tree/code/sm-cifs-rpc/cifs-rpc.h

     line 46, this doesn't work so well for printk and other things.
     please change to variable macro with one single call to printk.

nfx-tree/code/sm-cifs-rpc/pipe-api.c

     looks good

nfx-tree/code/sm-cifs/cifs-brlock.c

     looks good

nfx-tree/code/sm-cifs/cifs-close.c

     looks good

nfx-tree/code/sm-cifs/cifs-conn-api.h

     looks good

nfx-tree/code/sm-cifs/cifs-conn-struct.h

     looks good

nfx-tree/code/sm-cifs/cifs-conn.c

     looks good

nfx-tree/code/sm-cifs/cifs-csn.c

     looks good

nfx-tree/code/sm-cifs/cifs-ctc.c

     looks good

nfx-tree/code/sm-cifs/cifs-ctn.c

     looks good

nfx-tree/code/sm-cifs/cifs-delete.c

     looks good

nfx-tree/code/sm-cifs/cifs-echo.c

     line 11-19 the header spam is really depressing me.  it's in file
     after file.  i'm trying not to mention it over and over, but you
     are going to have to remove it from every file you cut and pasted
     the same 10 kernel header includes into.  perhaps i should just
     inject an overdose of heroin right now and get it overwith.  sigh.

nfx-tree/code/sm-cifs/cifs-find-close2.c

     looks good

nfx-tree/code/sm-cifs/cifs-flush.c

     looks good

nfx-tree/code/sm-cifs/cifs-ioctl.c

     looks good

nfx-tree/code/sm-cifs/cifs-kerb.c

     looks good

nfx-tree/code/sm-cifs/cifs-logoff.c

     looks good

nfx-tree/code/sm-cifs/cifs-negotiate.c

     looks good

nfx-tree/code/sm-cifs/cifs-nt-notify-change.c

     header spam

nfx-tree/code/sm-cifs/cifs-ntlmv2.c

     looks good

nfx-tree/code/sm-cifs/cifs-read-write.c

     looks good

nfx-tree/code/sm-cifs/cifs-req.c

     looks good

nfx-tree/code/sm-cifs/cifs-search.c

     looks good

nfx-tree/code/sm-cifs/cifs-security.c

     looks good

nfx-tree/code/sm-cifs/cifs-seek.c

     looks good

nfx-tree/code/sm-cifs/cifs-sess-setup.c

     looks good

nfx-tree/code/sm-cifs/cifs-smb-attributes.c

     looks good

nfx-tree/code/sm-cifs/cifs-smb-common.c

     looks good

nfx-tree/code/sm-cifs/cifs-smb-common.h

     looks good

nfx-tree/code/sm-cifs/cifs-smb-linkrename.c

     looks good

nfx-tree/code/sm-cifs/cifs-smb-ntcancel.c

     looks good

nfx-tree/code/sm-cifs/cifs-smb-open.c

     looks good

nfx-tree/code/sm-cifs/cifs-smb-sample.c

     looks good

nfx-tree/code/sm-cifs/cifs-tcon.c

     looks good

nfx-tree/code/sm-cifs/cifs-tdcon.c

     looks good

nfx-tree/code/sm-cifs/cifs-trans-browse.c

     looks good

nfx-tree/code/sm-cifs/cifs-trans-common.c

     looks good

nfx-tree/code/sm-cifs/cifs-trans-rap.c

     looks good

nfx-tree/code/sm-cifs/cifs-trans-util.c

     looks good

nfx-tree/code/sm-cifs/cifs-transact-nmpipe.c

     looks good

nfx-tree/code/sm-cifs/cs-api.c

     looks good

nfx-tree/code/sm-cifs/cs-msg.c

     looks good

nfx-tree/code/sm-cifs/ctn-struct.h

     looks good

nfx-tree/code/sm-cifs/ntifs.h

     looks good

nfx-tree/code/sm-cifs/win-compat.h

     looks good

nfx-tree/code/sm-cod/cod-api.c

     looks good

nfx-tree/code/sm-dcache/dcache-api.c

     line 2163 uh, no, uchar8 is toast, we're getting rid of it,
     so please don't change places to uchar8 that were previously fixed!

     lines 4439; 4443-4446 why are these commented out?  and why
     un-fixed to BSD_*?

     line 5487 this won't work with printk -- change this to use
     sprintf to a buffer, then call printk at line 5489

nfx-tree/code/sm-dcache/dcache-api.h

     line 808,824,1159 dude.  you're un-fixing u/char8 -> u/int8.
     i went to great lengths to fix these...


nfx-tree/code/sm-dcache/dcache-commit.c

     header spam

nfx-tree/code/sm-dcache/dcache-display.c

     more header spam.  i guess i'm mentioning it again because it's
     been 2 days since i was reviewing this.

nfx-tree/code/sm-dcache/dcache-hash.c

     line 718 why comment out this assert?


nfx-tree/code/sm-dcache/dcache-hash.h

     looks good

nfx-tree/code/sm-dcache/dcache-invalidate.c

     header spam

nfx-tree/code/sm-dcache/dcache-read.c

     header spam

     line 304 uint8 -> uchar8, you must be crazy


nfx-tree/code/sm-dcache/dcache-readahead.c

     header spam

nfx-tree/code/sm-dcache/dcache-readdir.c

     header spam

nfx-tree/code/sm-dcache/dcache-rx.c

     header spam

nfx-tree/code/sm-dcache/dcache-search.c

     header spam

nfx-tree/code/sm-dcache/dcache-struct.h

     looks good

nfx-tree/code/sm-dcache/dcache-tune.c

     header spam

     line 94 uchar8

nfx-tree/code/sm-dcache/dcache-tx.c

     header spam

nfx-tree/code/sm-dcache/dcache-util.c

     header spam

     line 164 uchar8

nfx-tree/code/sm-dcache/dcache-write.c

     header spam

     line 182 uchar8

nfx-tree/code/sm-debug/debug.h

     looks good

nfx-tree/code/sm-dp-proxy/dp-proxy-init.c

     header spam

     line 78-9, 162, uchar8

     line 132 this file doesn't get compiled twice, so this has to be
     figured out.

     line 164 80 column violation

     line 191 multiple style violations, incorrect spacing of function
     args, 80 columns...

     line 190 we're going to have to figure this out, because we can't
     compile this code twice in the same kernel



nfx-tree/code/sm-dp-proxy/dp-proxy-ui.c

     looks good

nfx-tree/code/sm-dp-proxy/dp-proxy.c

     line 447,450,454 uchar8

nfx-tree/code/sm-dp-proxy/dp-proxy.h

     line 148-9, 166, 168, 203 uchar8



nfx-tree/code/sm-elog/nt-log-strings.c

     looks good

nfx-tree/code/sm-esm/esm-api.h

     line 53,55 uchar8

nfx-tree/code/sm-event/event-mgr.c

     looks good

nfx-tree/code/sm-file/file-buf-api.c

     looks good

nfx-tree/code/sm-file/file-buf-struct.h

     header spam



nfx-tree/code/sm-file/file-lib.c

     header spam

     line 321,332 uchar8

nfx-tree/code/sm-file/file-msg.h

     looks good

nfx-tree/code/sm-file/file-server.c

     header spam

     line 388 please don't unfix this, it should remain tv_sec

     line 2005 indenting

     line 4961,4981,5025,5111  uchar8



nfx-tree/code/sm-gns/gns-api.c

     header spam

     line 2539 please don't un-fix tv_sec

nfx-tree/code/sm-hash/hash-api.c

     looks good

nfx-tree/code/sm-hash/hash.c

     looks good

nfx-tree/code/sm-icu-common/unicode/icu_wrappers.h

     line 19 uh, why'd you change this?  looks wrong.  it has to
     include slab.h

     line 251,284  uchar8



nfx-tree/code/sm-lock/lock-incls.h

     header spam

nfx-tree/code/sm-netbios/nb-api.h

     looks good

nfx-tree/code/sm-netbios/nb-cmd.c

     header spam



nfx-tree/code/sm-netbios/nb-ds.c

     header spam

nfx-tree/code/sm-netbios/nb-msg.c

     header spam

     line 338,432,537  uchar8

nfx-tree/code/sm-netbios/nb-ns.c

     header spam

     line 159-61,186,204,229,288,2158,2172 uchar8

nfx-tree/code/sm-netbios/nb-ss.c

     header spam

nfx-tree/code/sm-netbios/nb-tpl.c

     header spam



nfx-tree/code/sm-netbios/nb-util.c

     header spam

nfx-tree/code/sm-netbios/nb.c

     header spam

     line 65,67  uchar8



nfx-tree/code/sm-netbios/nb.h

     line 285 uchar8



nfx-tree/code/sm-nfs/ncp-api.c

     header spam

     line 1307 80 columns?  line 1308,1657  why is this commented out?



nfx-tree/code/sm-nfs/nfs-audit-api.c

     header spam

nfx-tree/code/sm-nfs/nfs-cmd-shell.c

     looks good

nfx-tree/code/sm-nfs/nfs-conn-api.h

     looks good

nfx-tree/code/sm-nfs/nfs-conn-struct.h

     looks good

nfx-tree/code/sm-nfs/nfs-conn.c

     header spam

     line 1383,1406,1411,1560-62,1872, indenting



nfx-tree/code/sm-nfs/nfs-dupcache.c

     line 18-22,24 none of these headers are needed -- except for
     socket they are all redundant.



nfx-tree/code/sm-nfs/nfs-globals.h

     looks good

nfx-tree/code/sm-nfs/nfs-module.c

     header spam



nfx-tree/code/sm-nfs/nfs-monitor-api.c

     the usual

nfx-tree/code/sm-nfs/nfs-notify-api.c

     the usual

	 line 262 uchar8

nfx-tree/code/sm-nfs/nfs-open-api.h

     hs



nfx-tree/code/sm-nfs/nfs-open.c

     hs



nfx-tree/code/sm-nfs/nfs-parse.c

     hs

     line 807 80-column?

     line 1113 uchar8



nfx-tree/code/sm-nfs/nfs-parse.h

     line 90,930 uchar8

     line 844 ug-ly



nfx-tree/code/sm-nfs/nfs-proc.c

     hs


nfx-tree/code/sm-nfs/nfs-reply.c

     hs

     line 1306,1348,1392,1669,1712,3239 uchar8

nfx-tree/code/sm-nfs/nfs-req-api.c

     hs

     line 1152,1558,1564,1572,1584,1587-8  indenting



nfx-tree/code/sm-nfs/nfs-req-api.h

     looks good

nfx-tree/code/sm-nfs/nfs-req-struct.h

     looks good

nfx-tree/code/sm-nfs/nfs-stats.c

     hs


nfx-tree/code/sm-nfs/nfs-string.c

     hs



nfx-tree/code/sm-nfs/ns-api.c

     hs


nfx-tree/code/sm-nfs/ns-api.h

     looks good

nfx-tree/code/sm-nfs/rpc.c

     hs

     line 1058, just delete it ~:^)



nfx-tree/code/sm-notify/notify-api.c

     hs



nfx-tree/code/sm-open/fcb-api.c

     line 1011 this is broken wrt printk.  use a variable macro instead
     with one call to printk

     line 6000-2 undo these changes please!  tv_sec is correct.



nfx-tree/code/sm-open/fns-api.c

     hs



nfx-tree/code/sm-open/ofh-api.c

     hs


nfx-tree/code/sm-open/open-api.c

     hs


nfx-tree/code/sm-open/symlink.c

     hs

nfx-tree/code/sm-open/vcb-api.c

     hs

     line 1939-40,1948,1995-2004,2021-27 tv_sec



nfx-tree/code/sm-oplock/oplock-api.c

     hs

nfx-tree/code/sm-oplock/oplock-cmd.c

     hs


nfx-tree/code/sm-queue/queue-api.c

     looks good

nfx-tree/code/sm-queue/queue.c

     line 121,144 at the very least make it printk.

nfx-tree/code/sm-req-queue/req-queue-api.c

     hs

nfx-tree/code/sm-req-queue/req-queue-api.h

     line 44-53, won't work with printk, use sprintf and a buffer
     instead.

     line 221, shouldn't this remain BSD_LIST_INIT?

nfx-tree/code/sm-req-queue/req-queue-struct.h

     line 34,35 at least make the comment line up with the line above

     line 260-269,275-286,305-7 column 80 violations?

nfx-tree/code/sm-req-queue/req-utils-api.c

     hs

     line 142 this should be BSD_

nfx-tree/code/sm-sbm-rev2/sbm-api.h

     line 237 uchar8


nfx-tree/code/sm-sbm-rev2/sbm-test.c

     looks good

nfx-tree/code/sm-scsi/scsi-api.h

     looks good

nfx-tree/code/sm-sdm/storage.c

     line 3257,3431,4330 uchar8

nfx-tree/code/sm-search/search-api.c

     hs

nfx-tree/code/sm-stats/hash_32.c

     looks good

nfx-tree/code/sm-stats/kpi-api.c

     hs



nfx-tree/code/sm-stats/kpi.h

     line 29 uh, not sure what to do here, 'cuz this isn't true
     anymore either.  probably fine to leave it actually.

nfx-tree/code/sm-stats/stats-client.c

     hs

nfx-tree/code/sm-stats/stats-dbg.h

     looks good

nfx-tree/code/sm-stats/stats-txrx.c

     looks good

nfx-tree/code/sm-stats/stats.c

     hs



nfx-tree/code/sm-stats/stats.h

     looks good


nfx-tree/code/sm-utils/cmd-utils.c

     looks good

nfx-tree/code/sm-utils/fs-rpc-api.c

     looks good

nfx-tree/code/sm-utils/txrx-utils-api.c

     hs

nfx-tree/code/sm-utils/utils-fs-api.h

     no, please revert this change to this file.  tv_sec.

nfx-tree/code/sm-utils/utils-fs.c

     looks good

nfx-tree/code/sm-vscan/vscan-api.c

     hs


nfx-tree/code/sm-vsvr/sfr-api.c

     hs


nfx-tree/code/sm-vsvr/vs-api.c

     hs

     line 239,241,244,256,25,261,etc this must be BSD_

     [many lines] feel free to get rid of the gratuitous space after
     printk since you're there anyway changing it from printf ~:^)

     how did you manage to remove BSD_ from everywhere that you're
     not compiling?



nfx-tree/code/sm-vsvr/vs-reloc-api.c

     hs

nfx-tree/code/sm-vsvr/vs-struct.h

     line 220 why'd this get moved?

     several uchar8's



nfx-tree/code/smoo-linux/bsd-dorf.c

     line 314-5, uh no reason to change this...

nfx-tree/code/smoo-linux/linux-stubs.c

     looks good



