AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Bill.Fisher@lsi.com>,<Brian.Stark@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	4BC38676.4080005@lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 12 Apr 2010 14:33:49 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Fisher, Bill" <Bill.Fisher@lsi.com>
Bcc: "Stark, Brian" <Brian.Stark@lsi.com>
Subject: Re: tuxrx Branch Change List 34077 review requested
Message-ID: <20100412143349.1bf07570@ripper.onstor.net>
In-Reply-To: <4BC38676.4080005@lsi.com>
References: <4B4FDE26.50003@lsi.com>
	<20100412133210.1392bcad@ripper.onstor.net>
	<4BC38676.4080005@lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 12 Apr 2010 14:45:42 -0600 William Fisher <bill.fisher@lsi.com>
wrote:

> Andrew Sharp wrote:
> > Resending.  There's quite a few files in here where I say "integrate
> > over and keep all the changes" or something along those lines.
> > Look at all the files in nfx-tree/code/{neteee2,tpl,ui} and any
> > other of your files that I ported over to the nfx-tree back in
> > 2009.  I may not have listed them all individually.  It's your
> > responsibility to track them down and take care of this since you
> > wanted to do it this way.
> > 
> 
> 	I will look at what is left ever. The code I gave you
> 	was obsolete shortly after you added it to the
> 	code/{tpl,netee2..} directories.

You didn't give it to me, I had to copy it from your tree.

> 	That code never was tested nor run hence it's
> 	highly doubtful that there is anything of use.
> 
> 	My kernel code has been tested and
> 	 is running right now, that code never
> 	loaded nor was ever run.

No amount of "argument" and no amount of talk is going to make this
task go away.  The reason it's never been run is that you have yet to
carry out your responsibility to merge these deltas into the files you
put in the kernel directory.

> > I told you many times, that if you were going to put your stuff in
> > the kernel directories, then you had to take these changes, and
> > that you can't just blow it off.  File by file is how it's done.
> > 
> 	Read my latest updates.

I don't have time to re-read and re-read.  I spent a couple of hours
Friday evening checking things out, and I found file after file that
has never been touched.  I sent you this list on Feb. 1st, and I
expected you to carry it out. Actually, I expected you to carry it out
*before* you ever submitted your changes for review.
