AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070523110546.2c6a056e@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E03CC143A@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 23 May 2007 11:05:54 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Ed Kwan" <ed.kwan@onstor.com>
Subject: Re: please review code change
Message-ID: <20070523110554.71c0fd71@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E03CC143A@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E03CC1437@onstor-exch02.onstor.net>
	<20070523101851.001cdfb9@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E03CC1439@onstor-exch02.onstor.net>
	<20070523104919.0171ea22@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E03CC143A@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Ed,

Looks good.



On Wed, 23 May 2007 10:55:09 -0700 "Ed Kwan" <ed.kwan@onstor.com> wrote:

> I see.
> Change number is 24062.
>  
> Thanks,
> Ed
> 
> ________________________________
> 
> From: Andy Sharp
> Sent: Wed 5/23/2007 10:49 AM
> To: Ed Kwan
> Subject: Re: please review code change
> 
> 
> 
> Use "p4 change" just like "p4 submit", except that it doesn't submit
> the change, it only puts it in a numbered changelist, rather than in
> "default" changelist.  Later you can submit it with "p4 submit -c
> <cl#>"
> 
> On Wed, 23 May 2007 10:44:39 -0700 "Ed Kwan" <ed.kwan@onstor.com>
> wrote:
> 
> > Hi Andy,
> > 
> > The client name is: edk-r220rel
> > I don't have a change #.  I thought I need the code reviewed before
> > I can "p4 submit"?
> > Thanks,
> > Ed
> >
> > ________________________________
> >
> > From: Andy Sharp
> > Sent: Wed 5/23/2007 10:18 AM
> > To: Ed Kwan
> > Subject: Re: please review code change
> >
> >
> >
> > Hi Ed,
> >
> > Can you give me a changelist #, and a p4 client name?  As long as
> > the client root is on mightydog, I feed that into my review script
> > and it takes care of everything for me.
> >
> > Thanks,
> >
> > a
> >
> > On Tue, 22 May 2007 18:14:48 -0700 "Ed Kwan" <ed.kwan@onstor.com>
> > wrote:
> >
> > > Hi Andy,
> > >
> > > This is for TED 19137.
> > > Client root: /homes/edk/p4/r220rel
> > > File: openbsd/src/lib/readline-4.1/signals.c
> > >
> > > The change comes from readline version 5.2 (attached).  Actually,
> > > there's minor bug in this new signals.c, line 303, which is the
> > > same as line 302.
> > >
> > > Thanks,
> > > Ed
> >
> >
> 
> 
