AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070613145409.4bf56459@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0221584B@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 13 Jun 2007 14:54:32 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Review Request
Message-ID: <20070613145432.6fb36a04@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0221584B@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0221584B@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

geez, be patient would ya?  you only sent this to me a month ago!


linux/src/openldap-2.3.30/build/onstor-rules.mk

     ok

linux/src/openldap-2.3.30/include/ldap_config.h

     line 55, shouldn't LDAP_DATADIR be /usr/share/openldap, or better
yet, /var/local/openldap?

linux/src/openldap-2.3.30/libraries/liblber/Makefile

     line 34, 69, 90, whitespace
     axe the #END at the end

linux/src/openldap-2.3.30/libraries/liblber/Makefile.ldap

     line 30, 49,125, 159, 178-204, 291, 345, whitespace
     looks like there is a lot of crap in here for cross compiling, are
you sure it doesn't cross- configure/build?

linux/src/openldap-2.3.30/libraries/libldap/Makefile

     line 35, 111, 137, whitespace
     axe the #END

linux/src/openldap-2.3.30/libraries/libldap/Makefile.ldap

     line 30, 49, 125, 159, 178-204, 295, 371, , whitespace

linux/src/openldap-2.3.30/libraries/libldap_r/Makefile

     line 35, 125, 151, whitespace
     axe the #END

linux/src/openldap-2.3.30/libraries/libldap_r/Makefile.ldap

     fix usual whitespace problems

linux/src/openldap-2.3.30/libraries/liblunicode/Makefile

     fix usual whitespace problems
     remove #END

linux/src/openldap-2.3.30/libraries/liblunicode/Makefile.ldap

     fix usual whitespace problems
     

linux/src/openldap-2.3.30/libraries/liblutil/Makefile

     fix usual whitespace problems
     remove #END

linux/src/openldap-2.3.30/libraries/liblutil/Makefile.ldap

     fix usual whitespace

linux/src/openldap-2.3.30/libraries/librewrite/Makefile

     fix usual whitespace
     BTW, hardcoding the prod to bl doesn't look right.  we will be
using this for cougar as well, and beyond, right?  this is in a lot of
the makefiles. 
     Get rid of the #END

linux/src/openldap-2.3.30/libraries/librewrite/Makefile.ldap

     usual whitespace bullcrap

nfx-tree/Tools/tool-chain-pkg.mk

     This is all more design review stuff than code review.  The code
looks fine. ------------------------
     i don't see how this file ties in.  for example, where does it do
different things with openbsd v. linux?
     what does make install_toolchain do in openbsd?
     line 17: says it's for linux, but i don't see anything in the
filename that would suggest that it's linux specific.







On Wed, 13 Jun 2007 14:30:09 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Did you get a chance to look at these? Should I ask someone else to
> review this?
> 
> Larry
> 
> _____________________________________________
> From: Larry Scheer 
> Sent: Monday, June 11, 2007 11:45 AM
> To: Andy Sharp
> Subject: Review Request
> 
> Change 24103 by larrys@larrys-verify-depot on 2007/05/25 11:57:22
> *pending*
> 
>         Onstor changes to OpenLDAP-2.3.30 source. Onstor Makefiles for
> ldap
>         libraries. Files named Makefile.ldap are the original LDAP
> Makefiles
>         created by the configure command. They are being checked in
> for reference purposes.
>         Reviewed by:
> 
> Affected files ...
> 
> ... //depot/cougar/linux/src/openldap-2.3.30/build/onstor-rules.mk#1
> add ... //depot/cougar/linux/src/openldap-2.3.30/include/ldap_config.h#1
> add ...
> //depot/cougar/linux/src/openldap-2.3.30/libraries/liblber/Makefile#1
> add
> ...
> //depot/cougar/linux/src/openldap-2.3.30/libraries/liblber/Makefile.ldap
> #1 add
> ...
> //depot/cougar/linux/src/openldap-2.3.30/libraries/libldap/Makefile#1
> add
> ...
> //depot/cougar/linux/src/openldap-2.3.30/libraries/libldap/Makefile.ldap
> #1 add
> ...
> //depot/cougar/linux/src/openldap-2.3.30/libraries/libldap_r/Makefile#1
> add
> ...
> //depot/cougar/linux/src/openldap-2.3.30/libraries/libldap_r/Makefile.ld
> ap#1 add
> ...
> //depot/cougar/linux/src/openldap-2.3.30/libraries/liblunicode/Makefile#
> 1 add
> ...
> //depot/cougar/linux/src/openldap-2.3.30/libraries/liblunicode/Makefile.
> ldap#1 add
> ...
> //depot/cougar/linux/src/openldap-2.3.30/libraries/liblutil/Makefile#1
> add
> ...
> //depot/cougar/linux/src/openldap-2.3.30/libraries/liblutil/Makefile.lda
> p#1 add
> ...
> //depot/cougar/linux/src/openldap-2.3.30/libraries/librewrite/Makefile#1
> add
> ...
> //depot/cougar/linux/src/openldap-2.3.30/libraries/librewrite/Makefile.l
> dap#1 add
> ... //depot/cougar/nfx-tree/Tools/tool-chain-pkg.mk#3 edit
