AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<tim.gardner@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E042A534B@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 15 Jun 2007 14:15:13 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Tim Gardner" <tim.gardner@onstor.com>
Subject: Re: code review
Message-ID: <20070615141513.30c9bbec@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E042A534B@onstor-exch02.onstor.net>
References: <20070614114746.4287ab2d@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E042A534B@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

oh, i think you meant 24244, ok.


On Fri, 15 Jun 2007 13:50:34 -0700 "Tim Gardner"
<tim.gardner@onstor.com> wrote:

> 29244
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Thursday, June 14, 2007 11:48 AM
> To: Tim Gardner
> Subject: Re: code review
> 
> OOh, excellent command
> 
> p4 change
> 
> creates a changelist, lets you edit the description and pick the
> files, and then saves the changelist.  later you can add or delete
> files to the changelist, etc.  you can submit the cl# 
> 
> 
> On Thu, 14 Jun 2007 10:45:24 -0700 "Tim Gardner"
> <tim.gardner@onstor.com> wrote:
> 
> > how do I get a cl without doing a submit?
> > 
> > -----Original Message-----
> > From: Andy Sharp 
> > Sent: Thursday, June 14, 2007 9:37 AM
> > To: Tim Gardner
> > Subject: Re: code review
> > 
> > All I wanted was a cl#.
> > 
> > On Wed, 13 Jun 2007 21:34:25 -0700 "Tim Gardner"
> > <tim.gardner@onstor.com> wrote:
> > 
> > > Huh? It is in a single change list. This code review process is
> > > what everyone uses. I don't want a separate process just for you.
> > > Set your P4CLIENT environemnt variable to timg-work and you can
> > > then just run a p4 diff. Doesn't get much simpler than that. If
> > > you have a script, then change the script.
> > > 
> > > ________________________________
> > > 
> > > From: Andy Sharp
> > > Sent: Wed 6/13/2007 4:57 PM
> > > To: Tim Gardner
> > > Subject: Re: code review
> > > 
> > > 
> > > 
> > > Hi Tim,
> > > 
> > > Please gather into a single changelist so I can use my handy
> > > script.
> > > 
> > > Thanks,
> > > 
> > > a
> > > 
> > > On Wed, 13 Jun 2007 16:40:03 -0700 "Tim Gardner"
> > > <tim.gardner@onstor.com> wrote:
> > > 
> > > > ?P4CLIENT timg-work
> > > >
> > > > changes to support chassisd
> > > >
> > > > //depot/cougar/linux/kernel/Makefile#4 - edit default change
> > > > (text) //depot/cougar/linux/kernel/linux-mips-2.6/.config#1 -
> > > > delete default change
> > > > (text)
> >
> //depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/reset
> > .c#1
> > > > - edit default change
> > > > (text) //depot/cougar/linux/kernel/linux-mips-2.6/bobcat-config#2
> > > > - edit default change
> > > > (text)
> > //depot/cougar/linux/kernel/linux-mips-2.6/drivers/char/mem.c#1
> > > > - edit default change
> > > > (text)
> >
> //depot/cougar/linux/kernel/linux-mips-2.6/drivers/char/watchdog/softdog
> > .c#1
> > > > - edit default change (text)
> > > 
> > > 
