AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070615172148.41f6e2be@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0221585F@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 15 Jun 2007 17:22:05 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: review req. for cw_install.in, try #67
Message-ID: <20070615172205.268c156e@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0221585F@onstor-exch02.onstor.net>
References: <20070615121627.3d750885@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0221585F@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 15 Jun 2007 16:39:58 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Line 4: "content weighted installation program"
>    Nice save!

The test is surrounded by if BUILD_TYPE = opt so it won't check except
for customers or tests of the whole system.  Besides, they can always
just insist on continuing.

> Lines 703-736: Your URL tests are too restrictive for internal use (QA
> and DEV.) If I give the URL:
> ftp://upgrade:password@10.0.0.143/home/upgrade/DEV/R4.0.0.DEV-BC-061407.
> tar.gz
> 
> I will get the message; "You have specified the wrong tarball for a
> Bobcat."
> 
> Which is incorrect, that is a valid bobcat URL. You need to whittle
> down `basename $ftp_url` to get just the pattern you are interested
> with something like sed, cut, or a nested case statement:
> 
> tarball=`basename $ftp_url`
> if [ ${tarball% BC.tar.gz} !=
> 
> You need to whittle down 
> 
> You may want to replace the if test logic with case statements so you
> can do pattern matches. Example:
> 
> case "$hwtype" in
>     BC)
> 	case `basename $ftp_url` in
> 		*${N_VERS}*BC*.tar.gz)
> 			: your golden
> 			;;
> 		*)
> 			record "You have specified the wrong tarball
> for a Bobcat."
> 			hwcross=1
> 			;;
> 	esac
> 	;;
> ...
> 
> If you are proficient with korn/bash shell pattern matching constructs
> which, I am not, you could switch the shell to korn shell and use
> those.
> 
> Line 917-918: The second nfxsh -e reboot -s is really needed?!! WOW! I
> would not have expected that.

Releases prior to 1.3.1 don't support the -y option, so the first line
will fail on 1.2.X releases, and then will execute the second line,
rebooting the system. Releases after that will never execute the second
line.

> -----Original Message-----
> From: Andy Sharp 
> Sent: Friday, June 15, 2007 12:16 PM
> To: Larry Scheer
> Subject: review req. for cw_install.in, try #67
> 
> Well, they threw away my original changelist -- those bastards! -- and
> one of the fixes that I guess I checked in before didn't work, so I
> had to fix the fix, and I decided to [quietly] add the ability to
> specify the URL on the command line and have it stick that in as the
> default URL, which I thought would take 2 seconds, but in reality
> took an hour.
> 
> So we have to re-review.
> 
> Change 24237 by andys@ripper on 2007/06/15 10:27:32 *pending*
> 
>         Obfuscate the ftp password after it is typed.
>         Tidy up default FTP URL.
>         Clean up some wording.
>         Tested both FTP and HTTP URLs.
>         Niced down the CF intensive processes to hopefully avoid
>           honking the filer unexpectedly.
>         
>         TED00019467 - CW-install : Without a password in the URL
>         TED00019490 - Users should not get the "You have successfully
>         TED00019491 - Reword second paragraph of the install script
>         TED00019489 - cw_install.sh failed to upgrade filer
>         TED00019493 - No check done if user downloads cheetah version
>         TED00019541 - cw_install.sh script from sub#23 fails to reboot
>         
>         Reviewed by larrys
> 
> Affected files ...
> 
> ... //depot/FB-DELOREAN/nfx-tree/Tools/cw_install.in#2 edit
> 
