AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<tim.gardner@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E04360566@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 18 Jun 2007 11:59:39 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Tim Gardner" <tim.gardner@onstor.com>
Subject: Re: code review
Message-ID: <20070618115939.20d1c13a@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E04360566@onstor-exch02.onstor.net>
References: <20070615180827.2386189a@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E04360566@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 18 Jun 2007 11:03:20 -0700 "Tim Gardner"
<tim.gardner@onstor.com> wrote:

> 

linux/kernel/linux-mips-2.6/.config

     looks good

linux/kernel/linux-mips-2.6/drivers/char/mem.c

     line 619, do_write_kmem advances ppos for you, so you don't have to
     do it yourself.

linux/kernel/linux-mips-2.6/drivers/char/watchdog/softdog.c

     looks good

nfx-tree/code/sendmail/Makefile

     looks good

nfx-tree/code/sm-chassis/Makefile

     looks good

nfx-tree/code/sm-chassis/chassis-ui.c

     line 1265, do you want to put this printf behind an #ifdef debug or anything?

nfx-tree/code/sm-chassis/chassisd-bc.c

     looks good

nfx-tree/code/sm-chassis/chassisd.c

     looks good

nfx-tree/code/sm-chassis/cm-util-bc.c

     looks good

nfx-tree/code/sm-chassis/cm.h

     looks good

nfx-tree/code/sm-chassis/linux.h

     looks good

nfx-tree/code/sm-chassis/openbsd.h

     looks good

nfx-tree/code/sm-ea/Makefile

     looks good

nfx-tree/code/sm-event/Makefile

     looks good

nfx-tree/code/sm-event/emrs-api.c

     looks good

nfx-tree/code/sm-event/linux-get-time.c

     if we don't need it, we don't need it

nfx-tree/code/sm-event/openbsd-get-time.c

     ditto

nfx-tree/code/sm-evm/Makefile

     looks good

nfx-tree/code/sm-file/Makefile

     looks good

nfx-tree/code/sm-fs/Makefile

     looks good

nfx-tree/code/sm-ipmd/Makefile

     looks good

nfx-tree/code/sm-sct/Makefile

     looks good

nfx-tree/code/sm-sdm/Makefile

     looks good

nfx-tree/code/sm-spm/Makefile

     looks good

nfx-tree/code/sm-tape/Makefile

     looks good

nfx-tree/code/ssc-authentication/Makefile

     looks good

nfx-tree/code/ssc-cluster/Makefile

     looks good

nfx-tree/code/ssc-elog/Makefile

     looks good

nfx-tree/code/ssc-genlib/Makefile

     add nfx-tree/code/ssc-genlib/Makefile

nfx-tree/code/ssc-genlib/genlib-linux.c

     add nfx-tree/code/ssc-genlib/genlib-linux.c
     
     line 1, 3, 5, 11 has trailing space at the end of the line
     line 34, 36, 54 has a tab or spaces on a blank line

nfx-tree/code/ssc-genlib/genlib-openbsd.c

     add nfx-tree/code/ssc-genlib/genlib-openbsd.c
     
     line 1, 3, 5, 11 has trailing space(s)

nfx-tree/code/ssc-genlib/genlib.h

     add nfx-tree/code/ssc-genlib/genlib.h
     
     ditto for this file

nfx-tree/code/ssc-ncm/Makefile

     looks good

nfx-tree/code/ssc-ndmp/Makefile

     looks good

nfx-tree/code/ssc-nfxnis/Makefile

     looks good

nfx-tree/code/ssc-nfxsh/Makefile

     looks good

nfx-tree/code/ssc-nfxsh/cmd_system-linux.c

     delete nfx-tree/code/ssc-nfxsh/cmd_system-linux.c
     
     ok

nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c

     delete nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c
     
     ok

nfx-tree/code/ssc-nfxsh/cmd_system.c

     looks good

nfx-tree/code/ssc-pm/Makefile

     looks good

nfx-tree/code/ssc-rmc/Makefile

     looks good

nfx-tree/code/ssc-sanm/Makefile

     looks good

nfx-tree/code/ssc-sshd-kb5/Makefile

     looks good

nfx-tree/code/ssc-timekeeper/Makefile

     looks good

nfx-tree/code/ssc-vsd/Makefile

     looks good

nfx-tree/code/ssc-vtm/Makefile

     looks good

