AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0451D5F1@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 27 Jun 2007 14:26:16 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20070627142616.06e462bf@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0451D5F1@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0451D5F1@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 26 Jun 2007 16:46:32 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> You must need a break from trying to get the flash to work.
> 
> Change 24344 by maximk@maximk-5 on 2007/06/22 16:27:44 *pending*
> 
>            Support for basic AF_EEE functionality, loopback only, no
> fragmentation.
> 
> Affected files ...
> 
> ... //depot/cougar/linux/kernel/linux-mips-2.6/drivers/Kconfig#1 edit
> ... //depot/cougar/linux/kernel/linux-mips-2.6/drivers/Makefile#1 edit
> ...
> //depot/cougar/linux/kernel/linux-mips-2.6/include/net/neteee/eee.h#1
> edit
> ... //depot/cougar/linux/kernel/linux-mips-2.6/net/Makefile#1 edit
> ... //depot/cougar/linux/kernel/linux-mips-2.6/net/neteee/neteee.c#1
> edit
> ... //depot/cougar/nfx-tree/code/sm-anpssc/Makefile#1 edit
> ... //depot/cougar/nfx-tree/code/sm-anpssc/anpssctest.c#1 add

linux/kernel/linux-mips-2.6/drivers/Kconfig

     looks good


linux/kernel/linux-mips-2.6/drivers/Makefile

     looks good


linux/kernel/linux-mips-2.6/include/net/neteee/eee.h

     line 3 (removal of nfx-types.h include)
     uh, say what? no, no, no, no, no, let's discuss
     thinking about it more, is this even the right name for this file?
     should there be a nfxeee.h kernel/userspace include file for eee
     definitions?  or is this nfx-types.h file something else altogether?

     line 60-61
     this is completely broken, what is this?  a richard-ism, i presume?

     line 77
     yeah, these prototypes probably don't belong in here.  or do they?

linux/kernel/linux-mips-2.6/net/Makefile

     looks good


linux/kernel/linux-mips-2.6/net/neteee/neteee.c

     line 63
     uh, not what i had in mind.  there's no "dragging" of header files.
     the combined kernel/userspace header file(s) need to be defined and
     coded, and the makefiles will take care of the rest at build time.
     So, all you have to do is the coding and defining part.  someone else
     will finish the makefile part.  someone else named larry.  after i
     teach him what is needed, which isn't much.

     line 977, 1050
     change to #ifdef DEBUG or similar equivalent
     actually, a module paramenter for debug level would be a good thing
     for this.

nfx-tree/code/sm-anpssc/Makefile

     line 48
     what is this?  either we need this file or we don't.
     i must be missing something.

     line 56
     excellent

nfx-tree/code/sm-anpssc/anpssctest.c

     >>add nfx-tree/code/sm-anpssc/anpssctest.c

     fix the trailing whitespace in places.

     nice.  where did this come from?  did we have it before or did you
     write it "just now"?

