AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E02215892@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 28 Jun 2007 11:52:05 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Review Request
Message-ID: <20070628115205.629006cc@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E02215892@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E02215891@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E02215892@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 26 Jun 2007 17:50:57 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Correction the copy of the changed sources in my home directory are
> in: /home/larrys/src/cougar/nfx-tree/code/ssc-sshd-kb5
> 
> _____________________________________________
> From: Larry Scheer 
> Sent: Tuesday, June 26, 2007 5:38 PM
> To: Andy Sharp
> Subject: Review Request
> 
> Andy,
>     This code is in my P4CLINET: larrys-r14-dmip on
> linux-compile:/home/larrys/perforce/trees/cougar/nfx-tree/code/ssc-sshd-
> kb5
> 
> I also have a copy in my home directory at:/homes
> /larrys/perforce/trees/cougar/nfx-tree/code/ssc-sshd-kb5
> 
> Change 24311 by larrys@larrys-r14-dmip on 2007/06/20 13:27:05
> *pending*
> 
>         Work to get SSHD version 4.2p1 to build for bobcat linux.
>         Reviewed by:
> 
> Affected files ...
> 
> ... //depot/cougar/nfx-tree/Makefile.ssc#6 edit
> ... //depot/cougar/nfx-tree/code/ssc-sshd-kb5/Makefile#5 edit
> ... //depot/cougar/nfx-tree/code/ssc-sshd-kb5/auth2-passwd.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-sshd-kb5/auth2-pubkey.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-sshd-kb5/auth2.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-sshd-kb5/defines.h#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-sshd-kb5/entropy.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-sshd-kb5/linux.h#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-sshd-kb5/linux.mk#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-sshd-kb5/monitor.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-sshd-kb5/openbsd.mk#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-sshd-kb5/session.c#1 edit
> ... //depot/cougar/nfx-tree/code/ssc-sshd-kb5/sshlogin.c#1 edit
> ... //depot/cougar/nfx-tree/openbsd.mk#2 edit


nfx-tree/Makefile.ssc

     looks good

nfx-tree/code/ssc-sshd-kb5/Makefile

     looks good

nfx-tree/code/ssc-sshd-kb5/auth2-passwd.c

     line 38
     why wouldn't it always include these files?

nfx-tree/code/ssc-sshd-kb5/auth2-pubkey.c

     looks good

nfx-tree/code/ssc-sshd-kb5/auth2.c

     line 69
     why would it be wrong to have this extern declaration always there?
     if it compiles without complaint, then you can get rid of the #ifdef

nfx-tree/code/ssc-sshd-kb5/defines.h

     looks good

nfx-tree/code/ssc-sshd-kb5/entropy.c

     looks good

nfx-tree/code/ssc-sshd-kb5/linux.h

     looks good

nfx-tree/code/ssc-sshd-kb5/linux.mk

     looks good

nfx-tree/code/ssc-sshd-kb5/monitor.c

     looks good

nfx-tree/code/ssc-sshd-kb5/openbsd.mk

     looks good

nfx-tree/code/ssc-sshd-kb5/session.c

     line 103
     same goes for this ifdef, you can probably remove it, no?

nfx-tree/code/ssc-sshd-kb5/sshlogin.c

     looks good

nfx-tree/openbsd.mk

     looks good


