AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070713101244.2d058197@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0485C837@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 13 Jul 2007 10:21:02 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20070713102102.50463b13@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0485C837@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0485C771@onstor-exch02.onstor.net>
	<20070712162639.05cf17fc@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0485C837@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

please revert setup.c from the changelist, thank you


On Thu, 12 Jul 2007 17:22:11 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> ok
> 
> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Thursday, July 12, 2007 4:27 PM
> >To: Maxim Kozlovsky
> >Subject: Re: Please review
> >
> >On Thu, 12 Jul 2007 15:39:25 -0700 "Maxim Kozlovsky"
> ><maxim.kozlovsky@onstor.com> wrote:
> >
> >> Change 24551 by maximk@maximk-5 on 2007/07/12 15:34:05 *pending*

linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/bobcat_bm_fpga.h

     looks good

linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/setup.c

     please revert this file

linux/kernel/linux-mips-2.6/drivers/serial/mpsc.c

     line 699
     no need to change this line



linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.c

     line 172
     comment and defines can be removed

     line 877
     use the macro for the irq, don't hardcode the number in the message


linux/kernel/linux-mips-2.6/include/asm-mips/mach-bobcat/bobcat.h

     line 98-101
     remove these defines

