AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0485CD23@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 13 Jul 2007 16:43:39 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20070713164339.5d844686@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0485CD23@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0485CD23@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 13 Jul 2007 16:18:07 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Change 24578 by maximk@maximk-5 on 2007/07/13 16:13:25 *pending*
> 
>         Set source port correctly.
>            Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/cougar/linux/kernel/linux-mips-2.6/net/neteee/neteee.c#4
> edit
> ... //depot/cougar/nfx-tree/code/sm-anpssc/anpssctest.c#3 edit
> 


linux/kernel/linux-mips-2.6/net/neteee/neteee.c

     line 749
     if the first two are always zero, why use conversions?
     just put 0/0/%d
     but i don't really care

nfx-tree/code/sm-anpssc/anpssctest.c

     looks good

