AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E049DEAF2@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 23 Jul 2007 11:14:48 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20070723111448.000c5383@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E049DEAF2@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E049DEAF2@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary=MP_QNWQkF7feU6AQdM994Qe_gl

--MP_QNWQkF7feU6AQdM994Qe_gl
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Mon, 23 Jul 2007 10:37:32 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> 
> Change 24676 by maximk@maximk-5 on 2007/07/23 10:11:17 *pending*
> 
>         Support for ip through fp ports.
>            Reviewed by andys.
> 
> Affected files ...
> 
> ...
> //depot/cougar/linux/kernel/linux-mips-2.6/include/net/neteee/eee.h#3
> edit
> ... //depot/cougar/linux/kernel/linux-mips-2.6/net/ipv4/datagram.c#1
> edit
> ... //depot/cougar/linux/kernel/linux-mips-2.6/net/ipv4/route.c#1 edit
> ... //depot/cougar/linux/kernel/linux-mips-2.6/net/ipv4/udp.c#1 edit
> ... //depot/cougar/linux/kernel/linux-mips-2.6/net/neteee/neteee.c#5
> edit
> ... //depot/cougar/nfx-tree/code/sm-anpssc/anpssctest.c#4 edit


--MP_QNWQkF7feU6AQdM994Qe_gl
Content-Type: text/plain; name=24676_review.out
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=24676_review.out

linux/kernel/linux-mips-2.6/include/net/neteee/eee.h

     looks good

linux/kernel/linux-mips-2.6/net/ipv4/datagram.c

     looks good

linux/kernel/linux-mips-2.6/net/ipv4/route.c

     looks good

linux/kernel/linux-mips-2.6/net/ipv4/udp.c

     looks good

linux/kernel/linux-mips-2.6/net/neteee/neteee.c

     line 142, curious, why did you change from 'inline' to '__inline'?

     line 1385
     i doubt the rest of the file is like this, but in general for debug
     prints, i prefer that we use a macro, something like this:

     eee_dbg(%s: receive relay packet: len = %d\n", __FUNCTION__, skb->len);

     that gets defined to null if EEE_DEBUG isn't defined.  that reduces
     the amount of ifdefs in the code.


     trailing whitespace on lines
     82
     83
     226
     286
     287
     362
     376
     499
     511
     611
     635
     676
     725
     743
     765
     776
     796
     839
     840
     844
     845
     851
     852
     877
     885
     887
     888
     965
     1146
     1211
     1261
     1293,4,5
     1324
     1327,8
     1330,1
     1333
     1375
     1381,2
     1386
     1388,9
     1398,9
     1455,6
     1469
     1476
     1528
     1571
     1583
     1595
     1598

nfx-tree/code/sm-anpssc/anpssctest.c

     looks good


--MP_QNWQkF7feU6AQdM994Qe_gl--
