AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070724154747.056fb59b@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<jeff.miller@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E018A69CF@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 24 Jul 2007 15:48:05 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Jeff Miller" <jeff.miller@onstor.com>
Subject: Re: PERFORCE change 24704 for review
Message-ID: <20070724154805.268139c7@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E018A69CF@onstor-exch02.onstor.net>
References: <20070724152036.1feaaf66@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E018A69CF@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

That's fine for a private convention, but it doesn't help someone else
6-9 months from now who is trying to determine if s/he needs to look at
these changes to see if they have anything to do with .... you see what
I mean.

 On Tue, 24 Jul 2007 15:27:35 -0700 "Jeff Miller"
<jeff.miller@onstor.com> wrote:

> It was stuff like adding comments, not anything that affects the
> compiled code.  
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Tuesday, July 24, 2007 3:21 PM
> To: Jeff Miller
> Subject: Re: PERFORCE change 24704 for review
> 
> On 24 Jul 2007 15:14:18 -0700 Jeff Miller <jeff.miller@onstor.com>
> wrote:
> 
> > Change 24704 by jeffm@jeffm-cougar on 2007/07/24 15:07:18
> > 
> > 	Minor cleanup.
> 
> Minor cleanup?  Are you going to know what that means six months from
> now?  Please try to be more explicit in the future with checkin
> comments.  Remember: it's a time capsule message to yourself (or
> someone like you) six months from now.
> 
> Thank you,
> 
> a
> 
> > 	Reviewed by: billn
> > 
> > Affected files ...
> > 
> > ... //depot/cougar/nfx-tree/code/sm-ispfc/ispfc_nvram.c#3 edit
> > ... //depot/cougar/nfx-tree/code/sm-ispfc/ispfc_scsi.c#5 edit
> > ... //depot/cougar/nfx-tree/code/sm-sanm-dm/sanm-dm-api.h#2 edit
> > ... //depot/cougar/nfx-tree/code/sm-sanm-dm/sanm-dm-private.h#3 edit
> > ... //depot/cougar/nfx-tree/code/sm-scsi/scsi-api.h#5 edit
> > ... //depot/cougar/nfx-tree/code/sm-scsi/scsi-disk-cmds.c#2 edit
> > ... //depot/cougar/nfx-tree/code/sm-scsi/scsi-msg.c#8 edit
> > ... //depot/cougar/nfx-tree/code/sm-scsi/scsi-tape-cmds.c#3 edit
> > ... //depot/cougar/nfx-tree/code/sm-scsi/scsi.c#5 edit
> > ... //depot/cougar/nfx-tree/code/sm-scsi/scsi.h#3 edit
> > 
> > 
> > http://liszt:1818/@md=d&cd=//depot/$c=G35@/24704?ac=10
