AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070724212638.1ec2fa40@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0221590B@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 24 Jul 2007 21:26:40 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: two reviews
Message-ID: <20070724212640.11998f01@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0221590B@onstor-exch02.onstor.net>
References: <20070720144733.7c82fe6a@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0221590B@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

We must be looking at 2 different files, but we can take as many cracks
at it as you like.

It builds now without specifying anything, which is one of the things
you were pushing for.  I forget the rest.


On Tue, 24 Jul 2007 19:54:34 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Hey Andy,
>    I am late with this review because I'm just not satisfied with how
> you changed things. I don't see how it is much of an improvement over
> what was there before. (kernel/Makefile)
> 
> Maybe we need to take another crack at this with clear heads and a
> fresh perspective.
> 
> Larry
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Friday, July 20, 2007 2:48 PM
> To: Larry Scheer
> Subject: two reviews
> 
> review #1:
> 
> This should be good enough for now.  I hope.
> 
> Change 24647 by andys@ripper on 2007/07/19 16:52:40 *pending*
> 
>         This may be Northern California, but in this case this is
>         just wrong!  But seriously, fix up the makefile logic a bit
>         to clue people in on what they are supposed to do, as well
>         as set things up for when we have a non NFS root.
> 
> Affected files ...
> 
> ... //depot/cougar/linux/kernel/Makefile#4 edit
> 
> =====================================================================
> 
> review #2: you only care about the files NOT in the .git directory.
> So that would be only the first 7 files.
> 
> 
> 
