AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070725113530.74b75147@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0221590D@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 25 Jul 2007 11:35:34 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: two reviews
Message-ID: <20070725113534.286d4593@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0221590D@onstor-exch02.onstor.net>
References: <20070724212640.11998f01@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0221590D@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 25 Jul 2007 11:17:34 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> I took a fresh look at the Makefile and the piece that bugged me most
> was the ROOTFS/NFSROOT section. Getting a warning message because you
> are using NFSROOT just doesn't seem right when the default behavior of
> the Makefile is to build NFSROOT. 

It's not a warning message that you are using nfs root, it's a message
telling you what you are using _as_ nfs root, since it is set for you if
you don't set it to something else, and what it sets it to might be a
"sorpreeze" to the user in that case.

> That logic is just too dubya.

Dubya has no logic.

> Later,
> 
> Larry 
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Tuesday, July 24, 2007 9:27 PM
> To: Larry Scheer
> Subject: Re: two reviews
> 
> We must be looking at 2 different files, but we can take as many
> cracks at it as you like.
> 
> It builds now without specifying anything, which is one of the things
> you were pushing for.  I forget the rest.
> 
> 
> On Tue, 24 Jul 2007 19:54:34 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > Hey Andy,
> >    I am late with this review because I'm just not satisfied with
> > how you changed things. I don't see how it is much of an
> > improvement over what was there before. (kernel/Makefile)
> > 
> > Maybe we need to take another crack at this with clear heads and a
> > fresh perspective.
> > 
> > Larry
> > 
> > -----Original Message-----
> > From: Andy Sharp 
> > Sent: Friday, July 20, 2007 2:48 PM
> > To: Larry Scheer
> > Subject: two reviews
> > 
> > review #1:
> > 
> > This should be good enough for now.  I hope.
> > 
> > Change 24647 by andys@ripper on 2007/07/19 16:52:40 *pending*
> > 
> >         This may be Northern California, but in this case this is
> >         just wrong!  But seriously, fix up the makefile logic a bit
> >         to clue people in on what they are supposed to do, as well
> >         as set things up for when we have a non NFS root.
> > 
> > Affected files ...
> > 
> > ... //depot/cougar/linux/kernel/Makefile#4 edit
> > 
> > =====================================================================
> > 
> > review #2: you only care about the files NOT in the .git directory.
> > So that would be only the first 7 files.
> > 
> > 
> > 
